chore(providers): clear standing clippy warnings
Pre-existing nits surfaced by recent clippy runs. No behavior change: - application/command/systemd: sort_by(|a,b| a.name.to_lowercase().cmp(...)) → sort_by_key(|i| i.name.to_lowercase()). The key form computes to_lowercase() once per element instead of twice per comparison. - providers/mod.rs (6 sites): descending score sort_by(|a,b| b.1.cmp(&a.1)) → sort_by_key(|x| std::cmp::Reverse(x.1)). - dmenu: add impl Default for DmenuProvider delegating to ::new(). cargo clippy now silent under --features full, --features lua, and --no-default-features. 268/268 lib tests still green.
This commit is contained in:
@@ -228,8 +228,7 @@ impl Provider for ApplicationProvider {
|
||||
);
|
||||
|
||||
// Sort alphabetically by name
|
||||
self.items
|
||||
.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase()));
|
||||
self.items.sort_by_key(|i| i.name.to_lowercase());
|
||||
}
|
||||
|
||||
fn items(&self) -> &[LaunchItem] {
|
||||
|
||||
@@ -99,8 +99,7 @@ impl Provider for CommandProvider {
|
||||
debug!("Found {} commands in PATH", self.items.len());
|
||||
|
||||
// Sort alphabetically
|
||||
self.items
|
||||
.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase()));
|
||||
self.items.sort_by_key(|i| i.name.to_lowercase());
|
||||
}
|
||||
|
||||
fn items(&self) -> &[LaunchItem] {
|
||||
|
||||
@@ -8,6 +8,12 @@ pub struct DmenuProvider {
|
||||
enabled: bool,
|
||||
}
|
||||
|
||||
impl Default for DmenuProvider {
|
||||
fn default() -> Self {
|
||||
Self::new()
|
||||
}
|
||||
}
|
||||
|
||||
impl DmenuProvider {
|
||||
pub fn new() -> Self {
|
||||
Self {
|
||||
|
||||
@@ -416,7 +416,7 @@ impl ProviderManager {
|
||||
})
|
||||
.collect();
|
||||
|
||||
results.sort_by(|a, b| b.1.cmp(&a.1));
|
||||
results.sort_by_key(|x| std::cmp::Reverse(x.1));
|
||||
results.truncate(max_results);
|
||||
results
|
||||
}
|
||||
@@ -458,7 +458,7 @@ impl ProviderManager {
|
||||
})
|
||||
.collect();
|
||||
|
||||
results.sort_by(|a, b| b.1.cmp(&a.1));
|
||||
results.sort_by_key(|x| std::cmp::Reverse(x.1));
|
||||
results.truncate(max_results);
|
||||
results
|
||||
}
|
||||
@@ -541,14 +541,14 @@ impl ProviderManager {
|
||||
scored_refs.select_nth_unstable_by(max_results, |a, b| b.1.cmp(&a.1));
|
||||
scored_refs.truncate(max_results);
|
||||
}
|
||||
scored_refs.sort_by(|a, b| b.1.cmp(&a.1));
|
||||
scored_refs.sort_by_key(|x| std::cmp::Reverse(x.1));
|
||||
|
||||
results.extend(
|
||||
scored_refs
|
||||
.into_iter()
|
||||
.map(|(item, score)| (item.clone(), score)),
|
||||
);
|
||||
results.sort_by(|a, b| b.1.cmp(&a.1));
|
||||
results.sort_by_key(|x| std::cmp::Reverse(x.1));
|
||||
results.truncate(max_results);
|
||||
return results;
|
||||
}
|
||||
@@ -617,14 +617,14 @@ impl ProviderManager {
|
||||
scored_refs.select_nth_unstable_by(max_results, |a, b| b.1.cmp(&a.1));
|
||||
scored_refs.truncate(max_results);
|
||||
}
|
||||
scored_refs.sort_by(|a, b| b.1.cmp(&a.1));
|
||||
scored_refs.sort_by_key(|x| std::cmp::Reverse(x.1));
|
||||
|
||||
results.extend(
|
||||
scored_refs
|
||||
.into_iter()
|
||||
.map(|(item, score)| (item.clone(), score)),
|
||||
);
|
||||
results.sort_by(|a, b| b.1.cmp(&a.1));
|
||||
results.sort_by_key(|x| std::cmp::Reverse(x.1));
|
||||
results.truncate(max_results);
|
||||
|
||||
#[cfg(feature = "dev-logging")]
|
||||
|
||||
@@ -128,8 +128,7 @@ impl Provider for SystemdProvider {
|
||||
|
||||
let stdout = String::from_utf8_lossy(&output.stdout);
|
||||
self.items = Self::parse_systemctl_output(&stdout);
|
||||
self.items
|
||||
.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase()));
|
||||
self.items.sort_by_key(|i| i.name.to_lowercase());
|
||||
}
|
||||
|
||||
fn items(&self) -> &[LaunchItem] {
|
||||
|
||||
Reference in New Issue
Block a user