search-update #44

Merged
anonfunc merged 4 commits from vikingowl/ALHP.GO:search-update into master 2021-09-20 22:09:20 +02:00
Contributor
  • Added SearchBar to NAV
  • Added Search-Feature to filter the tables
- Added SearchBar to NAV - Added Search-Feature to filter the tables
vikingowl added 2 commits 2021-09-20 17:07:42 +02:00
anonfunc added the
enhancement
label 2021-09-20 17:18:39 +02:00
anonfunc requested changes 2021-09-20 18:25:16 +02:00
anonfunc left a comment
Owner

Thanks for your PR.
I would like some changes to make it more readable.

Going to test if all works later.

Thanks for your PR. I would like some changes to make it more readable. Going to test if all works later.
@ -25,0 +39,4 @@
placeholder="Search for packages.."
class="form-control"
id="table-sort-input"
onkeyup="myFunction()"
Owner

Please choose a more accurate function name.

Please choose a more accurate function name.
vikingowl marked this conversation as resolved
@ -93,0 +140,4 @@
integrity="sha384-U1DAWAznBHeqEIlVSCgzq+c9gqGAJn5c/t99JyeKa9xxaYpSvHU5awsuZVVFIhvj"
src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.0/dist/js/bootstrap.bundle.min.js"
></script>
<script>
Owner

See above.

See above.
vikingowl marked this conversation as resolved
vikingowl added 1 commit 2021-09-20 18:31:14 +02:00
anonfunc reviewed 2021-09-20 21:40:50 +02:00
@ -25,0 +40,4 @@
class="form-control"
id="table-sort-input"
onkeyup="searchFilter()"
placeholder="Search for names.."
Owner

Duplicate placeholder

Duplicate `placeholder`
anonfunc marked this conversation as resolved
vikingowl added 1 commit 2021-09-20 22:08:19 +02:00
anonfunc merged commit c47d6f3cd2 into master 2021-09-20 22:09:20 +02:00
anonfunc referenced this issue from a commit 2021-09-20 22:09:20 +02:00
anonfunc deleted branch search-update 2021-10-24 05:05:01 +02:00
Sign in to join this conversation.
No description provided.