Fix firefox failing build #217
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "strptrk/ALHP.GO:fix_firefox"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi,
After some experimentation and digging in the firefox repository I realized that the commas in link-arg are the cause of the error.
Also, correct me if I'm wrong here, but you do not have to pass -Wl to the linker, cargo handles that. Plus, according to the documentation, it is possible to pass link-arg multiple times to achieve the same result.
I managed to build firefox locally with this change, so I guess this should work here as well.
Thanks for looking into this.
Did not know that passing them separately was possible. That makes for a relatively simple fix indeed.
I'll merge this and test the ff build.
Now we just need to wait for
nodejs 21.1.0
to leavetesting
. 😄Hi, I saw that the build failed again, this time for a different reason.
I ran into a similar issue, and the problem was an insufficient amount of RAM. I have 32GB of RAM, and had to add lots of swap space, because an LTO build of firefox used 73GB of RAM at its peak, during the linking phase.
You should either use Thin LTO to reduce the necessary amount of RAM, or just add a whole lot of swap.
Yep I noticed. Will add some swap.
EDIT: But since the
thunderbird
build(s) run successfully I except the ff builds will do the same (if they do not run out of memory in the middle of linking). So this PR fixed #197.