ALHP
/
ALHP.GO
6
34
Fork 9
Code Issues 29 Pull Requests Projects Releases Wiki Activity

Add -z pack-relative-relocs to RUSTFLAGS #196

Merged
anonfunc merged 1 commits from BertalanD/ALHP.GO:rust-relr into main 2023-06-05 17:19:48 +02:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
BertalanD commented 2023-06-05 17:12:58 +02:00
Contributor
Copy Link

rustc/cargo ignores LDFLAGS and requires the linker flags to be passed
via -Clink-arg= in RUSTFLAGS.

rustc/cargo ignores LDFLAGS and requires the linker flags to be passed via `-Clink-arg=` in RUSTFLAGS.
🎉 1
BertalanD added 1 commit 2023-06-05 17:12:58 +02:00
7d16607a31 Add `-z pack-relative-relocs` to RUSTFLAGS 
rustc/cargo ignores LDFLAGS and requires the linker flags to be passed
via `-Clink-arg=` in RUSTFLAGS.
anonfunc commented 2023-06-05 17:19:42 +02:00
Owner
Copy Link

LGTM

LGTM
anonfunc merged commit cbb2ea927d into main 2023-06-05 17:19:48 +02:00
anonfunc commented 2023-06-07 14:29:33 +02:00
Owner
Copy Link

I'm not sure if this PR is related, but FF is not failing to build with some RUSTFLAGS issue.

https://alhp.dev/logs/x86-64-v2/firefox.log

Did not find time to dig deeper yet. I found https://www.reddit.com/r/Gentoo/comments/13nq5rt/firefox_rustflags_issue/ after a quick search. Seems like link-args defined multiple times kills the ff build?

EDIT: Let's track this in #197.

I'm not sure if this PR is related, but FF is not failing to build with some `RUSTFLAGS` issue. https://alhp.dev/logs/x86-64-v2/firefox.log Did not find time to dig deeper yet. I found https://www.reddit.com/r/Gentoo/comments/13nq5rt/firefox_rustflags_issue/ after a quick search. Seems like link-args defined multiple times kills the ff build? *EDIT*: Let's track this in #197.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked upstream

   
bug

Something is not working

  
build-failure

package build fails because of our added buildflags

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
informational

Provides information about something

  
invalid

Something is wrong

  
invalid/corrupt package

Package needs to be rebuild

  
packaging issue

   
priority: high

High priority

  
question

More information is needed

  
support

   
wontfix

This won't be fixed

No Label
blocked upstream
bug
build-failure
duplicate
enhancement
help wanted
informational
invalid
invalid/corrupt package
packaging issue
priority: high
question
support
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ALHP/ALHP.GO#196
No description provided.
Delete Branch "BertalanD/ALHP.GO:rust-relr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?