add patching for rust flags #120
No reviewers
Labels
No Label
blocked upstream
bug
build-failure
duplicate
enhancement
help wanted
informational
invalid
invalid/corrupt package
packaging issue
priority: high
question
support
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: ALHP/ALHP.GO#120
Loading…
Reference in New Issue
No description provided.
Delete Branch "RubenKelevra/ALHP.GO:feat/rust_flags"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #110
1b25b863cctobe46f92cbe@ -734,0 +734,4 @@// enable rust flags and patch themmakepkgStr = strings.ReplaceAll(makepkgStr, "#RUSTFLAGS=", "RUSTFLAGS=")makepkgStr = strings.ReplaceAll(makepkgStr, "-C opt-level=2", "-C opt-level=3")makepkgStr = strings.ReplaceAll(makepkgStr, "-C opt-level=3", "-C opt-level=3 -C target-cpu="+march+" -C lto=fat -C codegen-units=1 -C strip=symbols -Z tune-cpu=generic -C linker-plugin-lto")-Zoptions are unstablerustcoptions that require the use of thenightlytoolchain and given that-Ztune-cpu=genericisn't strictly required, I would recommand not using it or any other unstable options.Ah yeah, it's just a null flag in this instance anyway. I have removed it from my own configuration in the meantime. Will do the same here. Thanks for pointing this out!
@anonfunc could you give this a review? :)
Sorry it took so long, work is very busy currently. I wanted to wait until I reworked how flags are added, but I can also port them over as soon as I get to that, so lets merge this.