Non-standard flags (GOAMD64) are actually not used

Piroro-hs commented

2022-09-12 17:19:25 +02:00

As stated in the man page of makepkg.conf, variables not in the makepkg's supported vars list is not exposed to build environment.

https://man.archlinux.org/man/makepkg.conf.5.en#DESCRIPTION

As stated in the man page of makepkg.conf, variables not in the makepkg's supported vars list is not exposed to build environment. https://man.archlinux.org/man/makepkg.conf.5.en#DESCRIPTION

anonfunc commented

2022-09-12 19:11:51 +02:00

Owner

Oh, I thought I remembered something about this, but I assumed the PR-creator was aware about that limitation and did their research. Seems like that was not the case, so we need to pass this differently then.

I'll have a look later, I'm currently somewhat busy with work.

Oh, I thought I remembered something about this, but I assumed the PR-creator was aware about that limitation and did their research. Seems like that was not the case, so we need to pass this differently then. I'll have a look later, I'm currently somewhat busy with work.

anonfunc added the

bug

label 2022-09-12 19:12:01 +02:00

anonfunc referenced this issue

2022-09-12 19:15:26 +02:00

Add fortran compiler flags #148

AvianaCruz commented

2022-11-25 11:21:31 +01:00

@anonfunc According to https://gitlab.archlinux.org/pacman/pacman/-/blob/v6.0.2/scripts/libmakepkg/buildenv.sh.in#L41, only the flags there are exposed to the build environment. So every additional environment variables MUST be manually exported.

anonfunc commented

2022-11-26 15:43:27 +01:00

Owner

We need to rewrite how ALHP exports these vars. Having them in the makepkg would be convenient, but requires patches to devtools. I'd like to avoid that, so we have no other option then to export them directly. I'll have to test if exporting them before executing makechrootpkg even works, since sudo or systemd-nspawn probably filters those env vars as well.

We need to rewrite how ALHP exports these vars. Having them in the makepkg would be convenient, but requires patches to devtools. I'd like to avoid that, so we have no other option then to export them directly. I'll have to test if exporting them before executing `makechrootpkg` even works, since sudo or systemd-nspawn probably filters those env vars as well.

anonfunc referenced this issue

2022-11-26 15:52:06 +01:00

Rust & LTO: I think I figured out what's wrong #157

AvianaCruz commented

2022-11-27 14:52:57 +01:00

@anonfunc I think exporting them before executing makechrootpkg will not work. The common way that works is placing export FOO=bar in makepkg.conf.

@anonfunc I think exporting them before executing makechrootpkg will not work. The common way that works is placing `export FOO=bar` in `makepkg.conf`.

anonfunc commented

2022-11-27 15:07:03 +01:00

Owner

That could work. Will have a test later.

anonfunc commented

2022-12-21 13:51:45 +01:00

Owner

@AvianaCruz If I understand correctly, we just need to add export in front of our non-makepkg recognized flags and it should work fine. I can implement that later today.

@AvianaCruz If I understand correctly, we just need to add `export` in front of our non-makepkg recognized flags and it should work fine. I can implement that later today.

anonfunc referenced this issue

2022-12-22 18:59:55 +01:00

Rust & LTO: I think I figured out what's wrong #157

anonfunc referenced this issue from a commit

2022-12-27 17:56:39 +01:00

export non-makepkg flags, resolves #149

anonfunc closed this issue

2022-12-27 17:56:39 +01:00

Non-standard flags (GOAMD64) are actually not used #149