Add fortran compiler flags #148

New Issue

Open

opened 2022-09-12 17:04:29 +02:00 by saltedcoffii · 4 comments

saltedcoffii commented

2022-09-12 17:04:29 +02:00

In /etc/makepkg.conf, we specify CFLAGS and CXXFLAGS (as does ArchLinux). I think we should also be specifying FFLAGS (flags to be passed to a fortran 77 compiler) and FCFLAGS (flags to be passed to a 9x compiler). Further documentation on this can be found in sections 8.14 and 8.15 in the automake documentation.

I would suggest:

...
CXXFLAGS="..."
FCFLAGS="$CFLAGS"
FFLAGS="$CFLAGS"
LDFLAGS="..."
...

I'm not very familiar with fortran, should we be adding more flags? Test compiles of programs including fortran code, such as libtool worked fine with this flag added. Additionally, should I open an issue with Arch Linux upstream and see what they think about these flags before we add them here, potentially letting Arch Linux devs add them?

In `/etc/makepkg.conf`, we specify `CFLAGS` and `CXXFLAGS` (as does ArchLinux). I think we should also be specifying `FFLAGS` (flags to be passed to a fortran 77 compiler) and `FCFLAGS` (flags to be passed to a 9x compiler). Further documentation on this can be found in sections 8.14 and 8.15 in the [automake documentation](https://www.gnu.org/software/automake/manual/automake.pdf). I would suggest: ``` ... CXXFLAGS="..." FCFLAGS="$CFLAGS" FFLAGS="$CFLAGS" LDFLAGS="..." ... ``` I'm not very familiar with fortran, should we be adding more flags? Test compiles of programs including fortran code, such as `libtool` worked fine with this flag added. Additionally, should I open an issue with Arch Linux upstream and see what they think about these flags before we add them here, potentially letting Arch Linux devs add them?

anonfunc added the

enhancement

label 2022-09-12 19:13:34 +02:00

anonfunc commented

2022-09-12 19:15:26 +02:00

Owner

As #149 describes, makepkg needs to know about that var otherwise it's not exported. So I think the only way besides a patched makepkg is to get it upstreamed or use whatever solution we can come up with for #149 (which affects GOAMD64).

saltedcoffii commented

2022-09-12 20:21:04 +02:00

Author

https://bugs.archlinux.org/task/75893

Alright, let's see what happens.

https://bugs.archlinux.org/task/75893 Alright, let's see what happens.

👍 3

saltedcoffii commented

2022-09-13 12:25:41 +02:00

Author

To anyone who sees this:
If you have an Arch Linux Bugs account (or want to make one anyway) please go upvote this bug as fixing it is required to make any headway on this issue. Thanks so much for helping this amazing project as well as Arch Linux!

To anyone who sees this: If you have an Arch Linux Bugs account (or want to make one anyway) please go upvote [this bug](https://bugs.archlinux.org/task/75893) as fixing it is required to make any headway on this issue. Thanks so much for helping this amazing project as well as Arch Linux!

anonfunc referenced this issue from a commit

2023-06-03 13:47:30 +02:00

added fortran compiler flags #148

anonfunc commented

2023-06-03 13:47:59 +02:00

Owner

I added them to our flags to be exported in the makepkg.conf.

I added them to our flags to be exported in the `makepkg.conf`.