Files
vikingowl ec9433d783 chore(lint): clear remaining errcheck and staticcheck findings
Brings the project to a clean `make lint` baseline (0 issues).

Mechanical:
- Wrap deferred resp.Body.Close() in closures (router/discovery.go,
  router/probe.go) so the unchecked return surfaces as `_ = ...`.
- Apply `_ = ...` (single or multi-return blank) to test-file calls
  that intentionally ignore errors: os.MkdirAll / os.WriteFile / os.Chdir
  in setup paths, Close / Shutdown in teardown, Submit / Spawn / Send /
  LoadDir in tests that assert on side effects.

Structural:
- engine.handleRequestTooLarge drops the unused req parameter and
  rebuilds the request from compacted history (SA4009 — argument was
  overwritten before first use).
- provider.ClassifyHTTPStatus and google.applyCapabilityOverrides switch
  to tagged switches over the discriminator (QF1002).
- tui.app.go MouseWheel + inputMode and cmd/gnoma main slm-status use
  tagged switches in place of equality chains (QF1003).
- cmd/gnoma main.go merges a var decl with its immediate assignment
  (S1021).
- Three empty-branch sites (dispatcher_test, loader_test,
  coordinator_test) become real assertions or get the dead `if` removed
  (SA9003).
2026-05-19 17:53:42 +02:00

98 lines
2.5 KiB
Go

package router
import (
"bytes"
"context"
"encoding/json"
"log/slog"
"net/http"
"slices"
)
// probeLlamaCppToolSupport queries the llama.cpp /props endpoint to determine
// if the loaded model supports tool calling. Returns false on any error
// (conservative: unknown = no tools).
func probeLlamaCppToolSupport(ctx context.Context, baseURL string) bool {
ctx, cancel := context.WithTimeout(ctx, discoveryTimeout)
defer cancel()
req, err := http.NewRequestWithContext(ctx, "GET", baseURL+"/props", nil)
if err != nil {
return false
}
resp, err := http.DefaultClient.Do(req)
if err != nil {
return false
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != 200 {
return false
}
var result struct {
ChatTemplateCaps struct {
SupportsTools bool `json:"supports_tools"`
SupportsToolCalls bool `json:"supports_tool_calls"`
} `json:"chat_template_caps"`
}
if err := json.NewDecoder(resp.Body).Decode(&result); err != nil {
slog.Debug("llamacpp /props decode failed", "error", err)
return false
}
caps := result.ChatTemplateCaps
supported := caps.SupportsTools && caps.SupportsToolCalls
slog.Debug("llamacpp tool probe",
"supports_tools", caps.SupportsTools,
"supports_tool_calls", caps.SupportsToolCalls,
"result", supported,
)
return supported
}
// probeOllamaToolSupport queries Ollama's /api/show endpoint to determine
// if a specific model supports tool calling. Returns false on any error.
func probeOllamaToolSupport(ctx context.Context, baseURL, modelName string) bool {
ctx, cancel := context.WithTimeout(ctx, discoveryTimeout)
defer cancel()
body, err := json.Marshal(map[string]string{"model": modelName})
if err != nil {
return false
}
req, err := http.NewRequestWithContext(ctx, "POST", baseURL+"/api/show", bytes.NewReader(body))
if err != nil {
return false
}
req.Header.Set("Content-Type", "application/json")
resp, err := http.DefaultClient.Do(req)
if err != nil {
return false
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != 200 {
return false
}
var result struct {
Capabilities []string `json:"capabilities"`
}
if err := json.NewDecoder(resp.Body).Decode(&result); err != nil {
slog.Debug("ollama /api/show decode failed", "model", modelName, "error", err)
return false
}
supported := slices.Contains(result.Capabilities, "tools")
slog.Debug("ollama tool probe",
"model", modelName,
"capabilities", result.Capabilities,
"supports_tools", supported,
)
return supported
}